Product List: Replace full product objects with simplified objects #15966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmeichigo
added
feature: product details
…ead-can-cause' into woomob-619-product-list-update
Collaborator
|
|
…ead-can-cause' into woomob-619-product-list-update
itsmeichigo
removed
the
feature: product details
RafaelKayumov
approved these changes
Aug 4, 2025
Contributor
RafaelKayumov
left a comment
RafaelKayumov
left a comment
There was a problem hiding this comment.
LGTM. Products, variations, bundles look fine.
Comment on lines
361
to
363
| func listItem(at indexPath: IndexPath) -> T.ListItemType { | ||
| return controller.object(at: indexPath).toListItem() | ||
| } |
1 task
…ead-can-cause' into woomob-619-product-list-update
…ead-can-cause' into woomob-619-product-list-update
Collaborator
Generated by 🚫 Danger |
…ead-can-cause' into woomob-619-product-list-update
Contributor
Author
|
@RafaelKayumov I also added changes in this PR to use a separate type for product list on the view layer. Due to complications with batch product update, I added a workaround to get list items for the product list without using the generic results controller as discussed in #15959. Please take another look when you can. cc @jaclync |
RafaelKayumov
approved these changes
Aug 5, 2025
Base automatically changed from
woomob-619-xcode-warnings-performing-io-on-the-main-thread-can-cause
to
trunk
August 7, 2025 01:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WOOMOB-619
Description
This PR continues the work in #15959 to improve the performance on the product list by loading simplified product objects instead of full ones.
Changes include:
ProductListItemwith new stock-related properties needed for displaying on product list items.selectFirstProductIfAvailablein product list to fetch full object for only the item at first index, not the whole list.Some helpers added:
toListItemextension method for Product to allow product search list and paginated list selector to continue working with the full objects. This is to keep the scope of this PR small.createStockTexta String extension to be reusable across different types, not justProductFormDataModel.Testing steps
Testing information
Tested and confirmed on simulator iPhone 16 iOS 18.4.
Screenshots
No UI changes.
RELEASE-NOTES.txtif necessary.